Skip to content

Do not generate grid-column when configuring grid-column-start or grid-column-end; Similar for grid-row #18907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 10, 2025
Merged

Do not generate grid-column when configuring grid-column-start or grid-column-end; Similar for grid-row #18907

merged 6 commits into from
Sep 10, 2025
+124 −40

Conversation

@RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Sep 9, 2025 •
edited
Loading

This PR fixes an issue where configuring a custom --grid-column-start or --grid-column-end also generated a grid-column utility due to the overlapping namespace.

@theme {
  --grid-column-start-custom: custom-start;
  --grid-column-end-custom: custom-end;
}

Would then generate:

.col-end-custom {
  grid-column: var(--grid-column-end-custom);
}
.col-start-custom {
  grid-column: var(--grid-column-start-custom);
}
.col-start-custom {
  grid-column-start: var(--grid-column-start-custom);
}
.col-end-custom {
  grid-column-end: var(--grid-column-end-custom);
}

Instead of the expected:

.col-start-custom {
  grid-column-start: var(--grid-column-start-custom);
}
.col-end-custom {
  grid-column-end: var(--grid-column-end-custom);
}

This fix is also applied to grid-row when configuring --grid-row-start and --grid-row-end

Fixes: #18906

@RobinMalfait RobinMalfait requested a review from a team as a code owner September 9, 2025 17:28
@RobinMalfait RobinMalfait enabled auto-merge (squash) September 9, 2025 19:31
philipp-spiess
philipp-spiess reviewed Sep 10, 2025
View reviewed changes
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the same issue exists for --grid-row?

From my WIP PR:

Image

@RobinMalfait RobinMalfait changed the title Do not generate grid-column when configuring grid-column-start or grid-column-end Do not generate grid-column when configuring grid-column-start or grid-column-end; Similar for grid-row Sep 10, 2025
@RobinMalfait
Copy link
Member Author

@philipp-spiess ah yep; I'm sure there are more cases but I still want to fix this in a more generic way somehow.

For now, updated the PR to handle both --grid-column and --grid-row

@RobinMalfait RobinMalfait mentioned this pull request Sep 10, 2025
Merged
@RobinMalfait RobinMalfait merged commit 340b59d into main Sep 10, 2025
7 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-18906 branch September 10, 2025 13:57
@chrisbbreuer chrisbbreuer mentioned this pull request Oct 20, 2025
Open
1 task
This was referenced Oct 21, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Grid column start and end generating grid-column: css properties

2 participants

@RobinMalfait @philipp-spiess